Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak vscode and mocha tooling somewhat #2133

Merged
merged 2 commits into from
Dec 31, 2022

Conversation

boneskull
Copy link
Contributor

@boneskull boneskull commented Dec 29, 2022

The Mocha changes are just refactors/housekeeping, but the VS Code changes improve the workflow for a vscode development environment.

Mocha

  • Sorted the JSON
  • Added a $schema ref
  • Use require: ts-node/register here
  • Remove require: ts-node/register from scripts in package.json

VS Code

  • Creates some build and watch tasks
  • Removed invalid task
  • Update build_themes.js to run async and support watch mode (watch mode cannot run using esbuild.buildSync())

- Sorted the JSON
- Added a `$schema` ref
- Use `require: ts-node/register` here
- Remove `require: ts-node/register` from scripts in `package.json`
- Creates some build and watch tasks
- Removed invalid task
- Update `build_themes.js` to run async and support watch mode (watch mode cannot run using `esbuild.buildSync()`)
Copy link
Collaborator

@Gerrit0 Gerrit0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -4,16 +4,81 @@
"version": "2.0.0",
"tasks": [
{
"label": "build",
"label": "build-tsc",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, guess you can tell how often I actually use these... I always just have yarn build:tsc running in a terminal.

@Gerrit0 Gerrit0 merged commit 2d60647 into TypeStrong:master Dec 31, 2022
@Dayday10
Copy link

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants